Rafał Miłecki

Results 156 comments of Rafał Miłecki

@Seriousness: OK, I like the idea of getting some ideas from UBL for field names where it makes sense. Without being too strict about it. I'm afraid some names may...

Every output module expects **array of extracted data** (array of dictionaries) as argument. See how `main()` handles it in the `main.py`: ``` output = [] for f in args.input_files: res...

I can implement this but I need `invoice2data` maintainers to help me to decide on YAML syntax for it. I have two suggestions. @m3nu: can you comment on below ideas,...

> Instead of this I was thinking if the lines section could be made like the tables section. Where we could give multiple entries. That would be really helpful The...

Please provide output of `invoice2data` call with `--debug` option set. From a quick review that `(Pence)` in your `start` smells fishy. Did you mean `\(Pence\)` or maybe `(Pence)?`?

Your template (YML file) contains regex for `date` but that isn't enough. It's required to also extract `amount` and `invoice_number`. Please edit your template (YML file) and add `amount` and...

[Preview of updated `TUTORIAL.rst`](https://github.com/rmilecki/invoice2data/blob/tutorial-fields/TUTORIAL.rst)

In #311 we shortly discussed following some names documented in UBL. This Pull Requests adds: - ``email``: does it make sense to replace it with ``electronic_mail`` (to match ``ElectronicMail``)? -...

I've updated this pull request. Preview: https://github.com/rmilecki/invoice2data/blob/tutorial-fields/TUTORIAL.md#fields Suggested documented `fields` names: 1. `company_id` - based on UBL's [cbc:CompanyID](https://docs.peppol.eu/poacc/billing/3.0/syntax/ubl-invoice/cac-AccountingSupplierParty/cac-Party/cac-PartyTaxScheme/cbc-CompanyID/) 2. `electronic_mail` - based on UBL's [cbc:ElectronicMail](https://docs.peppol.eu/poacc/billing/3.0/syntax/ubl-invoice/cac-AccountingSupplierParty/cac-Party/cac-Contact/cbc-ElectronicMail/) 3. `telephone` - based on...

That comes from `sort_keys=True` in the `src/invoice2data/output/to_json.py`. I think we have two options: 1. Drop `sort_keys=True` 2. Update `SammyMaystoneLinesTest.json` (sort its keys) I think that `sort_keys=False` would be more natural...