Romain Manni-Bucau
Romain Manni-Bucau
@kriegaex I did 9 days ago: https://github.com/apache/maven-shade-plugin/pull/104#pullrequestreview-698569810 I'm clearly not blocking, just pointing out that as written this PR does not solve the mentionned issue so, as written, I'm fine...
@kriegaex ok so let say I disagree the warning is heritant and think it reveals a real bug we can fix. Also logging in debug is hiding by nature since...
> My fix is not dirty! It cleans up a dirty situation. As explained, I can agree with that if you find a proof the fact the folder is in...
> It is not rocket science to understand that it is perfectly normal for directories to be on the classpath. In a classpath yes, in a shade build it is...
@JanMosigItemis hmm, not sure I fully got it but if `target/` it is unexpected and it should be stripped early (instead of lately ignored), if `target/classes` it must not be...
Another path separator issue :(, fixed hopefully
Updated the PR, I think the test is more relevant for this particular case than an IT since we don't care how it runs but we care about what it...
Can depend on the SPI PR, could be replaced by a SPI module IMHO.
Common sounds a good alternative but too generic, I thought about "auto" but was not that happy too. Maybe "autoConfigure" + adding a spi on transformers and filters would make...
Hmm, i thought of that - active by default and ignored if set by the user - but it is rare it is sufficient and does need a log4j, openwebbeans...