maven-shade-plugin icon indicating copy to clipboard operation
maven-shade-plugin copied to clipboard

[MSHADE-307] defaults for transformers and filters

Open rmannibucau opened this issue 6 years ago • 7 comments

Following this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles, where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [ ] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

rmannibucau avatar Dec 19 '18 09:12 rmannibucau

What about adding some description about new default in this page ? https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html

eolivelli avatar Dec 19 '18 09:12 eolivelli

@rfscholte please take a look

eolivelli avatar Dec 19 '18 09:12 eolivelli

@rmannibucau tests are failing on Jenkins https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/MSHADE-307/1/

eolivelli avatar Dec 19 '18 14:12 eolivelli

Another path separator issue :(, fixed hopefully

rmannibucau avatar Dec 19 '18 14:12 rmannibucau

good https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/MSHADE-307/2/

eolivelli avatar Dec 19 '18 14:12 eolivelli

Updated the PR, I think the test is more relevant for this particular case than an IT since we don't care how it runs but we care about what it runs, let me know if it is still an issue.

rmannibucau avatar Dec 20 '18 08:12 rmannibucau

Can depend on the SPI PR, could be replaced by a SPI module IMHO.

rmannibucau avatar Apr 11 '20 07:04 rmannibucau