Romain Manni-Bucau
Romain Manni-Bucau
@kriegaex updated a bit the PR but think it can be worth importing/adding your test on top of it to harness the code, do you want to do it and...
+1 to move forward, this feature will become important with jakartaee 9
@rfscholte do you still think we shouldn't have this kind of transformer wrapper or are we ok to merge?
@rfscholte hmm, what about the comment that a chain does not work compared to a wrapper?
@rfscholte a chain does not enable to inherit from dynamic resources so I don't see how you aim at making it work, did I miss sthg?
@rfscholte it is by design since the canTransformResource impl delegates to underlying transformers so if the underlying transformer is dynamic then it works. Chaining does not work cause there is...
@rfscholte the plugin yes but it means it requires another configuration or feature external to transformers. It can work but it is way less composable and becomes more specific. Concretely...
Ok, will release it on github to unblock people waiting after it. That said I'd still want to make it part of shade plugin cause it is just aligned on...
Hi @JanMosigItemis , did you check why you hit a directory? too early custom execution? Note that it needs a test that the directory classpath element service is still listed...
@kriegaex I guess the expectation is to fix the cause instead of ignoring it so can be a thing slowing down merge button push maybe - at least for me.