Romain Malmain

Results 90 comments of Romain Malmain

> @rmalmain is this still relevant? Fixed in #1928 normally. It's not so easy to reproduce exactly the environment of docs.rs to follow the same build. Hopefully, this will be...

> also, renaming QemuHelper is a good idea IMO, something like QemuTool (like pintool lol) or QemuInstrumentation I also agree `QemuHelper` is misleading, we should change it IMHO (we have...

With this implementation, GenericInProcessExecutor stores (in addition to its internal state) the state of the parent structure (like `QemuExecutor` inner state). It's quite unnatural, but it works out well. Is...

> > GenericInProcessExecutor stores (in addition to its internal state) the state of the parent structure (like QemuExecutor inner state). > > which part does this? i only see QemuExecutorWithState...

> > It's basically GenericInProcessExecutor, with the state of the parent structure (here QemuExecutorWithState) embedded inside. > > Ok. Will it feel less odd if you rename `QemuExecutorState` to `QemuInternalState`?...

I applied the renaming propositions. Is there any other remark for this PR?

I found the issue, I'll open a pr soon

The main issue there is for now is that it requires changing harnesses' signatures. I am thinking of a way to wrap this so it does not change the signature...

@andreafioraldi, a minimized version of the problem here: [Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=08b636faa2d5a27f5a0507a9809c3baa) (It's also on Discord). The core problem is that the harness does not necessarily take a `&mut Self` as the second...

It should be in good shape now, there should only be minor things to clean up. In the end, I didn't exactly follow your idea @domenukk. Instead, I created a...