Romain Malmain
Romain Malmain
To pass the reference of the state to expose to the internal `Executor`. Example: `QemuExecutor` contains an `InProcessExecutor` and calls its `run_target` function in its own `run_target` definition. There are...
If you do this, there will be an overhead no? Or you need to store some kind of reference to the state to expose, and then have a self-referencing struct...
If we use metadata the executor state is then owned by the map, so even when we need to access the executor state for other things, we need to perform...
> also is it not possible to simply add another member into `InProcessWithStateExecutor` and make this guy have some member like `self.my_executor_state: EM`? Hum, then in that case the state...
I don't think we need this, QemuExecutorState is just a wrapper around the old members of `QemuExecutor` and they were not stored as metadata afaik.
Closed in favor of #1900.
The PR is getting closer to something we could merge. There are still some issues I need to address before: - [x] Find a solution to get QEMU hooks generically...
The PR is now in a reviewable state. What has been changed since the last comment: - Most of (all?) the extern declarations have been moved to `libafl_qemu_sys` - Now,...
I agree the use of `Clone` for `Emulator` is inappropriate. In fact, `Emulator` is allowed to be initialized **once per process** and is usually accessed through the `Emulator::new_empty` or `Emulator::get`...
Thanks a lot for the debugging work. I'll have a look today