Lance Martin

> > > > > > Not sure if i'm following it here, EmbeddingsFilter and EmbeddingsRedundantFilter existed before right? > > The prev PR added EmbeddingsClusteringFilter. The clustering it's a...

Overall, this is great. Just add a notebook example of how to use this stand-alone w/ a vectostore and k > 5 to demonstrate larger-scale retrieval. And also `poetry run...

> > > > Yeap the lint stuff it's weird I have black set by default on vscode... but is not catching all the same formatting issues it seems. Looks...

Thanks!

Thanks for these updates; a few merge conflicts w/ `master` (perhaps after merging the other two docstring PRs). Do you mind merging / rebasing `master` and resolving?

Nice work @raymond-yuan. Can you merge master to resolve conflicts and have a look at any Lint errors (I just kicked off tests again)?

> I have merged master at https://github.com/flepied/langchain/tree/relevance_refactor and it seems to work well with my tests... Great. When @raymond-yuan is back online, I'll let him resolve the merge conflicts. I...

I'll have a look today and aim to get this in.

@raymond-yuan I see tests for chroma, faiss, pgvector, singlestore. but a larger set of DBs (pinecone, etc) are modified; tests for some like pinecone are tricky b/c they are not...

> relevancy score function already implemented, these should be no-ops and completely backwards compatible Ya, agreed. Cool, thanks for running some additional tests. Going to merge this now, esp given...