Lance Martin

@mertkayhan can you please resolve: ``` poetry run ruff . langchain/vectorstores/elastic_vector_search.py:48:89: E501 Line too long (89 > 88 characters) ``` I probably can't push to your branch since `fsn_capital` is...

See lint errors. You can run `make format` or the below locally to test before pushing: ``` poetry run black . poetry run mypy . poetry run ruff . --fix...

> Hello @rlancemartin, I have a "1 change requested", but i can not change something. Is the process blocked? @pprados thanks for the detailed explanation. Also adding @baskaryan and @eyurtsev...

> Question 1: > > What is the precise problem with RetrievalQAWithSourcesChain? > > * The challenge lies in returning the precise source documents employed for generating answers in RAG....

> @rlancemartin Please, review this PR again. TNX! I'm on paternity leave currently (new baby). Thanks for looking into this. I can have a look when I'm back in October...

Nice. Yes. This is good. Consolidating `document_transformers` in a new dir will make additions easier going forward. Like @baskaryan said, https://github.com/hwchase17/langchain/pull/7379 is going in soon.

> @baskaryan Added it as a document transformer. I'm still not 100% sure this is the best approach. > > I mean it works, but will force using compressors everywhere...

Also, in general: IIUC, this is a re-ordering of documents after retrieval (similar post-processing as something like Cohere re-rank). Re-rank is a vectorstore wrapper: https://python.langchain.com/docs/modules/data_connection/retrievers/integrations/cohere-reranker I'll have a look at...

> > Also, in general: IIUC, this is a re-ordering of documents after retrieval (similar post-processing as something like Cohere re-rank). Re-rank is a vectorstore wrapper: > > https://python.langchain.com/docs/modules/data_connection/retrievers/integrations/cohere-reranker >...

Unrelated to this PR, but on the theme - Do we have redundancy between `EmbeddingsFilter` [here](https://github.com/hwchase17/langchain/blob/master/langchain/retrievers/document_compressors/embeddings_filter.py) in `document_compressors` ... ... and `EmbeddingsRedundantFilter` [here](https://github.com/hwchase17/langchain/blob/master/langchain/document_transformers/embeddings_redundant_filter.py) in `document_transformers`? The second one went in...