Lance Martin

Results 95 comments of Lance Martin

Note: I'm using `poetry lock --no-update` to re-generate `poetry.lock` after checking out `master` `pyproject.toml`. Good for future reference when you see conflicts w/ `poetry.lock`.

> Oof that's odd, I can't think of any way it would have leaked through Doctran. It's not in the repo and we don't send openai keys to any API....

Error due to lib flipped back to async - ``` ╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮ │ in :1 │ │ │ │ ❱ 1 transformed_document = await qa_transformer.atransform_documents(documents)...

Adding @baskaryan re: creation of `document_transformers` subdir and moving [document_transformers.py ](https://github.com/hwchase17/langchain/blob/master/langchain/document_transformers.py) to `langchain/document_transformers/embeddings_redundant_filter.py`

This is good to go in once @jasonwcfan adds init methods and does a final sweep of Notebooks w/ init. @baskaryan minor point that Vercel deploy test is failing (non...

Thanks @baskaryan! Great. Should we wait for the Vercel fix?

@inferense thanks! Do you mind added a simple notebook with example usage to `langchain/docs/modules/indexes/document_loaders/examples/` (e.g., something like [this](https://github.com/rlancemartin/langchain/blob/e1fa1a41d0b2d7f476627a6798e98f02ebe4a83d/docs/modules/indexes/document_loaders/examples/youtube_audio.ipynb))? I'm very interested to test this.

Thanks! Is it worth adding any examples of this functionality [to the notebook](https://github.com/hwchase17/langchain/blob/master/docs/extras/modules/data_connection/vectorstores/integrations/elasticsearch.ipynb)? And I welcome @jeffvestal's review, too. Also please run `make format` to resolve Lint errors.

Thanks! Please run "make format" to resolve Lint errors.