RJ Duffner
RJ Duffner
going to close this pr. @dhofstetter has a more complete implementation. thanks @dhofstetter and @ocelotl
Nice @dhofstetter. Thanks for taking this on. Looks like my pr #1939 is fully implemented here. I can close #1939 when this is done.
@xrmx, take a look at this one. I still need to do some doc updates but I think this is a better option vs #2537
@emdneto, it looks like fastapi and fastapi-slim do something similar ``` fastapi: pip install opentelemetry-api@{env:CORE_REPO}\#egg=opentelemetry-api&subdirectory=opentelemetry-api fastapi: pip install opentelemetry-semantic-conventions@{env:CORE_REPO}\#egg=opentelemetry-semantic-conventions&subdirectory=opentelemetry-semantic-conventions fastapi: pip install opentelemetry-sdk@{env:CORE_REPO}\#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk fastapi: pip install opentelemetry-test-utils@{env:CORE_REPO}\#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils fastapi: pip install...
@emdneto Ha, I just saw that and was fighting with bugs in the tests and switched my code back to doing it the way the fix for fastAPI is doing...
@xrmx and @emdneto Thanks for the feedback. I think it is all integrated at this time.
@xrmx, I updated the tox to switch everything to kafka-pythonng from kafka-python-ng. However, now the action only installs the kafka-python-ng instrumentation and doesn't actually test with it because I didn't...
@emdneto cool, ill do the same here. Thanks for the confirmation.