Ritchie Vink

Results 1120 comments of Ritchie Vink

Just out of curiosity, when did this trigger a problem? I've never encountered one whilst running `python -m ...` with the .venv activated.

Sorry for the delay on my part. Seeing the discussion, I agree on > The original solution in this PR: add the current directory to PYTHONPATH and move on. Can...

Thanks for the overview @alamb. I am in favor of proposal 3. Where the core buffers are in `arrow-rs` and we have `arrow2` as an alternative API/kernels/IO layer on top...

> I think this is a problem of us not doing both SLICE and PREDICATE PUSHDOWN. Yes, we must accept a prefilter slice and a postfilter slice in the readers....

Yes, this will be properly handled by a cache manager in the new streaming engine. It is known, but we don't continue the old streaming engine as it will be...

Thank you @Fokko. Can you add a test as well?

In this function we test several predicate pushdowns in pyarrow datasets: https://github.com/pola-rs/polars/blob/6a873242c84a81c7eecd394b330799a86a6d51d6/py-polars/tests/unit/io/test_pyarrow_dataset.py#L32

Right, I understand the sentiment. Given that we name the iterator over `Option` `iter` and the iterator over `&str` `iter_values`, I think it would be better to rename `from_slice` to...

I think this one can be closed as there has changed a lot since then.

Yes, it is accepted. But I believe it was fixed by #18027