polars icon indicating copy to clipboard operation
polars copied to clipboard

fix(rust): Fix `sink_ipc_cloud` panicking with a Tokio runtime error

Open Qqwy opened this issue 1 year ago • 2 comments

Fixes #13614

When writing ot ObjectStore-compatible storage in the IPC format, it seems like the .block_on calls inside the constructed CloudWriter might sometimes get called inside another block_on call. Tokio does not like this, resulting in a panic.

This PR resolves this issue by using block_on_potential_spawn in the necessary places instead.

Qqwy avatar Feb 04 '24 18:02 Qqwy

Hi @stinodego! I am sorry for the ping, but is there something blocking this PR or something we could do to get it merged? Thank you! :heart:

josevalim avatar Jun 21 '24 16:06 josevalim

I'm still available to (help) fix(ing) the merge conflicts once more if needed, but it would be nice if it can be merged soon afterwards before new conflicts would arise 😅

Qqwy avatar Jun 21 '24 17:06 Qqwy

I think this is now conflicting with my fix from https://github.com/pola-rs/polars/pull/18027 I'm also available to help if needed :)

It seems that this fix would also fix the issue https://github.com/pola-rs/polars/issues/13163

philss avatar Aug 06 '24 15:08 philss

I think this one can be closed as there has changed a lot since then.

ritchie46 avatar Aug 07 '24 06:08 ritchie46

Is a fix still accepted? The functionality is currently broken and we would be happy users of it. Thank you :)

josevalim avatar Aug 07 '24 07:08 josevalim

Yes, it is accepted. But I believe it was fixed by #18027

ritchie46 avatar Aug 07 '24 07:08 ritchie46

I'm afraid this was not fixed yet. I could reproduce the error with the latest version from the main branch. Here is the backtrace: https://gist.github.com/philss/a81fab6f9cf85d23a0f1c364633e992b

philss avatar Aug 07 '24 17:08 philss