Ralph Giles

Results 129 comments of Ralph Giles

We weren't able to see the issue following these steps. Could you please provide full code which reproduces the issue? You might also try your current setup against git master...

Parts of this, like the `def` file, should definitely be merged, but I'm not confident I can update the patch properly.

For other opus libraries, people have contributed cmake build configurations, which would be the preferred way to build it, except no one has done that for opusfile yet. Note that...

If you can fix this in 5 minutes, please submit a PR!

@ihsinme Thanks for the patches. Can you say a bit more about what issue you're trying to address? Do you think this is a correctness problem? Are you trying to...

The appveyor integration test failure is an unrelated issue fixed in 894d1b1f22f2fb8ab6d3aeba863e143416c71ce2. A rebase should complete without error.

Just because the assigned variable is floating point doesn't mean the calculations must all be floating point. We are free to choose at what points integer inputs are converted. For...

Please also add some documentation about why the export list changed to the commit message, so anyone looking for the change has an easier time understanding the motivation.

That's correct. If we're changing the vorbis.dll ABI I think we should change it for all the builds.