Ralph Giles

Results 129 comments of Ralph Giles

As far as I can tell, you're correct here, and this hasn't been implemented. The underlying `libopusenc` stream encoder implementation does lpc interpolation into the padding of the final packet,...

Corrections from Jean-Marc on IRC: > LPC at the beginning is tricky for the general case. > > You can't do it after resampling because the resampling itself is going...

The `DURATION` there is a tag added by the encoder (ffmpeg?) not the duration opusdec sees. Do you get the same issue if you encode the original wav with opusenc?...

Would `--discrete` or `--discrete-channels` make more sense for this use case? I worry `--no-surround` doesn't really make sense with two input channels. How do you use the `--coupled` option? It...

The more-recent `read-event` example [uses](https://github.com/ringbahn/ringbahn/blob/7cb9499/examples/read-event.rs#L20) `ringbahn::print!` which afaict is an async version of the macro. So possible in this context, but perhaps not necessary? I guess for this particular line...

This is a follow-up to #32, attempting to respond to the review request. FWIW I agree that submitter's `rb::foo::bar` style is more pedagogical, but in a code this size referring...

We'd be interested in a `Zeroize` impl as well.

> We'd be interested in a `Zeroize` impl as well. Sorry, `zeroize::Zeroize` is not `ByteMuck::Zeroable`. I opened #172 since it's a different dependency.

We could still benefit from deploying this fix while rusty-binder is under development. @Sean1708, if you're not interested in merging, would you be willing to add one of us to...

This is the same as #49.