Riley Karson
Riley Karson
Closing this as stale given the last activity was some time ago (6mo+). Please feel free to reopen or open a new PR if you pick it back up!
Closing this as stale given the last activity was some time ago (6mo+). Please feel free to reopen or open a new PR if you pick it back up!
@slevenick do you mind taking this review? I've been spread a bit thin recently. There's some internal context if you need it (but hopefully it's clear in the context of...
Hmm- I'd lean towards keeping it this way as the field is a list of strings: https://github.com/hashicorp/terraform-provider-google-beta/blob/f590ae668a68f3c004f621b13cb72ca3ddc5b919/google-beta/services/compute/resource_compute_firewall.go#L398-L411 Terraform does do fairly aggressive [type conversion](https://developer.hashicorp.com/terraform/language/expressions/types#type-conversion) that means that your examples work,...
They're valid for the reason I linked above, but I think we should stick more to the strict string type.
Apologies, I've seen this and have run the tests a couple times but haven't had the cycles to sit down and exhaustively determine if it's safe or not. This is...
Has the API been fixed and can we proceed or should we close this?
Closing old do not merge PRs.
Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs in "Draft" last updated over a month ago. This doesn't...
Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs last updated over 3 months ago. This doesn't represent rejection...