Riley Karson

Results 276 comments of Riley Karson

This field doesn't appear in the API docs for some reason: https://cloud.devsite.corp.google.com/secure-web-proxy/docs/reference/network-services/rest/v1/projects.locations.gateways The null value (omitting the field / an empty string) maps to `EXPLICIT_ROUTING_MODE` so today you'd leave the...

I may be missing something but most of the code should be shared between the two resources already, either through [`nodePoolUpdate`](https://github.com/GoogleCloudPlatform/magic-modules/blob/fd83651d4a73687d34391692d243ed1927c1af7e/mmv1/third_party/terraform/services/container/resource_container_node_pool.go.erb#L1349) or [`node_config.go`](https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/container/node_config.go.erb). `nodePoolUpdate` should probably live in `node_config.go` for...

Ah- I misinterpreted this as an issue with `google_container_cluster.node_pool`, not `google_container_cluster.node_config`, by reading the thread out of order / not reading the actual title 🤦 . Thanks! > Unless that's...

The change in https://github.com/GoogleCloudPlatform/magic-modules/pull/11697 matches what I'd have recommended, yeah; we could also consider refactoring the equivalent section in `nodePoolUpdate` into a function but I personally prefer just repeating it...

> At a nuts and bolts level, the idea would be to make a new function in node_config.go and then call it, for example, from here at top level? Yep!...

> It would be a nice side effect if it changes for this made it eventually possible for this to be handled more gracefully (or maybe at some point the...

I also have https://github.com/GoogleCloudPlatform/magic-modules/pull/11978 out which fixes the _specific cause of that error_ (but still doesn't accurately model the API- we send the message we expect, and still have a...

> Is there an appropriate forum to ask question regarding provider contributions? Generally just on the issues themselves- we don't monitor additional channels for those kinds of questions. > If...

> As noted https://github.com/hashicorp/terraform-provider-google/issues/11367#issuecomment-1096766211 gcloud is just doing a lot of HTTP calls behind the scenes to find the tag value based on the namespacedName, so the HTTP API doesn't...

@shuyama1 can you investigate? We suspect this may be a test environment issue more than a test config issue.