GoogleCloudPlatform
Add new compute-firewall-policy-with-rules resource
Add a new resource to allow updating all rules in firewall policy at once.
Fixes https://github.com/hashicorp/terraform-provider-google/issues/19195
Release Note Template for Downstream PRs (will be copied)
`google_compute_firewall_policy_with_rules` (beta)
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@slevenick do you mind taking this review? I've been spread a bit thin recently. There's some internal context if you need it (but hopefully it's clear in the context of the PR alone)
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 518 insertions(+))
google-beta provider: Diff ( 5 files changed, 2686 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 474 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_compute_firewall_policy_with_rules (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_compute_firewall_policy_with_rules" "primary" {
rule {
target_resources = # value needed
}
}
Tests analytics
Total tests: 997 Passed tests: 917 Skipped tests: 78 Affected tests: 2
Click here to see the affected service packages
- compute
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
- TestAccComputeFirewallPolicyWithRules_update
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample[Debug log]
TestAccComputeFirewallPolicyWithRules_update[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 520 insertions(+))
google-beta provider: Diff ( 5 files changed, 2687 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 471 insertions(+))
Tests analytics
Total tests: 1000 Passed tests: 922 Skipped tests: 76 Affected tests: 2
Click here to see the affected service packages
- compute
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
- TestAccComputeFirewallPolicyWithRules_update
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample[Debug log]
TestAccComputeFirewallPolicyWithRules_update[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.