Steven Rieder

Results 306 comments of Steven Rieder

This is another Astropy attempt at adding compatibility: https://github.com/astropy/astropy/pull/10205

Closing this issue in favour of #687 which probably requires a broader solution.

When astropy is installed, AMUSE quantities now have an "as_astropy_quantity" method that converts to astropy.

> What was the conclusion, though, for things like `Msun`? Just convert to `Msun` or go through `kg` and take into account possibly different definitions? I solved this by going...

It doesn't yet have unittests - these would need to be added before we could merge this in AMUSE

Looks to be in good shape. I'll test when I can and make a PR.

"beta quality" package by @merijn is at https://github.com/nlesc/homebrew-nlesc

I'll check. Also, #196 may be somewhat related to this.

The test_issue_850 workflow tests issue #850 - it currently fails so the bug is still there (of course, since no fix has been made yet). I'm not sure what causes...