amuse icon indicating copy to clipboard operation
amuse copied to clipboard

Add falcon module to AMUSE

Open rieder opened this issue 4 years ago • 5 comments

@eugvas has written an interface for the fast-multipole gravity solver "falcON" (W.Dehnen, ApJL, 536, 9, 2000) from NEMO: https://github.com/GalacticDynamics-Oxford/pyfalcon Let's see if we can include this in AMUSE / what is needed to do this.

rieder avatar Jul 14 '21 13:07 rieder

It doesn't yet have unittests - these would need to be added before we could merge this in AMUSE

rieder avatar Jul 14 '21 13:07 rieder

here is my first attempt for a unit test: test_pyfalcon.py.txt

eugvas avatar Jul 16 '21 22:07 eugvas

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 04 '22 15:03 stale[bot]

It would be great if this could be opened back up again! I think having a falcon implementation in AMUSE would be very helpful for many.

jnibauer avatar May 31 '22 00:05 jnibauer

Looks to be in good shape. I'll test when I can and make a PR.

rieder avatar May 31 '22 03:05 rieder