Peter Burns

Results 156 comments of Peter Burns

Could use hasOwnProperty to tell if a field from Object is being overwritten on the clonee.

Hm, maybe we should use the [`cloneNode`](https://developer.mozilla.org/en-US/docs/Web/API/Node/cloneNode) method when dealing with document nodes? Can confirm that this fails in Safari 10.1: ```javascript Object.create(Object.getPrototypeOf(document.createElement('div'))).align = 'foo' ``` but this does not:...

> My main question is: if a test is written using eval(), and we ship this change, will the test now fail when run in a Trusted-Types-supporting browser? If so,...

I'm not 100% sure I follow. You'd like to see a test of native Trusted Types functionality? A test that only runs in Chromium browsers and would fail if the...

Useragent: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.15063 Version: 40.15063.0.0

I believe that the original reason for this bug no longer matters

I also want to say that wasm-pack-template, wasm-pack, rust, and this entire cluster of tools and libraries have been super impressive, and besides this issue they've been a really great...

Maybe I'm missing something, but how would this handle multiple files that depend on `some-itertools` that each use different subsets of the file? Would each bespoke version of `some-itertools` need...

In 0.5 land we provided something like this: https://github.com/Polymer/paper-elements/blob/master/paper-elements.html It's useful for convenience. On the other hand, it's something of a performance footgun, which might be why we're not providing...