Peter Burns

Results 156 comments of Peter Burns

+1 to this. This came up in the new linter.

The tedium update was specifically because it's a js file that you can't read (without doing a bower install). It was easy enough to work around, but it did cause...

Sorry for the delay, I was out for the holidays! This is just the nature of Polymer's synchronous data binding and observing. What are you doing in your observer, and...

I can see the convenience argument here, but then we would end up with multiple sources of truth, causing issues like: ``` javascript var ironUrl = document.querySelector('iron-page-url'); ironUrl.addEventListener('url-changed', function() {...

A workaround for your issue @akc42 would be to call: ``` javascript window.history.pushState({}, null, '/api/csv/xxx?params'); window.dispatchEvent(new CustomEvent('location-changed')); ``` That's a cheap and easy way to update the URL and notify...

Applied my suggestion and marked it to merge. Thanks for the contribution!

Interesting, I can't get the `f && f()` form to be dead code eliminated on the terser playground, even when f is const undefined and the file is a module....

What's the delta in binary size?

@justinfagnani the delta was printed as a comment but now you can find it as part of the PR, see commit https://github.com/lit/lit/pull/3918/commits/1d39495fa34f15fb5e91888d0bb3a4d4650be784