Federico Targa

@Sandy4321 In my opinion, the code is not complicated such that it needs documentation as you suggest. Functions that start with "_" are private, and shouould not be your concern,...

@AbdulHassan0  source: https://finance.yahoo.com/quote/MSFT/key-statistics/ when I run the following snippet: ```python3 import yfinance as yf msft = yf.Ticker("MSFT") print(msft.info) ``` ```python3 ebitda: 98841001984 ``` what is your source for that...

> This looks awfully over-engineered (and in wrong file). Can I suggest you look into test-driven development? Write tests first that specify behaviour, then implement. Would you mind being more...

I don't think _get_ticker_tz is doing what you think it is doing. Furthermore, it can potentially send out a get request out to, url = "{}/v8/finance/chart/{}".format(self._base_url, self.ticker), which doesn't seem...

@ValueRaider Updated with ```_parse_user_dt```. it looks like it's working nicely now. The function was missing an exception for invalid datetimes. Where do you think is best to put this code?

> Most of the diff changes aren't related to this feature, can you fix that? Rebase to `dev`, then revert the splitting code over lines. Makes review much easier. Yes...

We could send the request with beautiful soup and check whether `next` is an active link or not. If it is then we scan the page to which the link...

can you give us some more context? what are you trying to do here? in the meantime, you should check the type of all variables with type. It seems like...

@ValueRaider Is `calendar` essentially doing the same as `earnings_dates`?

@ValueRaider is there a bug to fix though? I guess I don't understand why we are trying to merge two incompatible dataframes. Maybe someone who's interested can shed some lights...