Ricky

Results 317 comments of Ricky

@avkonst thanks for submitting, continuing the discussion from https://github.com/facebook/react/issues/20609. It's very common for stack traces to point to React internals where the issue is sourced in user code. Since you're...

@avkonst thanks a ton for following up and reducing the code down. The issue is that DevTools errors when a custom hook is named `useState`. If you rename the custom...

Yeah, I agree, it probably shouldn't error but I don't have a much context as @bvaughn so let's wait to see what he says. In the meantime, I've created a...

And thanks @dai-shi for debugging this as well, nice find!

@bvaughn in your smaller version, I don't think you need the useEffect

There are two issues happening here for snapshots: - Not mocking the draftjs `Editor` (which has random keys in data attributes) - Using `EditorState.createWithContent()` in props, which has random key...

I like that! Seems like a great use case for a [custom matcher](https://facebook.github.io/jest/docs/en/expect.html#expectextendmatchers)

In Jest 23 we added a [snapshot property matcher](https://jestjs.io/docs/en/snapshot-testing#property-matchers) for this use case: ``` it('will check the matchers and pass', () => { const user = { createdAt: new Date(),...

Note: this is also reproducible on https://react-rte.org/demo. From the Markdown spec on [handling paragraphs](https://daringfireball.net/projects/markdown/syntax#p), two spaces and a newline should create a line break: > When you do want to...

I think the next step is to for someone interested to submit a PR