Ricky

icon indicating a website link https://rickhanlon.codes

icon company @facebook icon location EST. AKRON icon location React Core @facebook

Results 318 comments of Ricky

Adding testIDs on LogBox to make it easier to detect warnings/errors in automation

@samuelfreiberg thanks for submitting the PR and driving this feature. In my mind, there are three separate requests here, with different solutions for each: - Detecting if the UI is...

Bug: Allow suppressing warning message "Warning: `key` is not a prop. Trying to access it will result in `undefined` being returned. If you need to access the same value within the child component, you should pass it as a different prop."

I don't understand the issue, if you do `Logger.log(props);` you don't get the error? Can you provide an example that does not log `props.key` specifically (which is always a bug,...

Bug: Allow suppressing warning message "Warning: `key` is not a prop. Trying to access it will result in `undefined` being returned. If you need to access the same value within the child component, you should pass it as a different prop."

No, accessing `props.key` or rendering a list without a key is a bug and we do not provide APIs for ignoring warning to prevent bugs. You will only see the...

Bug: Uncaught TypeError: Cannot read properties of null (reading 'useMemo') [React 18.3.1]

Yeah @owenn2106 did you update your `react-dom` version as well?

a

Thanks, but we don't accept PRs that make minor naming changes because they tend to go in circles and introduce subtle bugs.

Allow the branch to be changed during watch mode

Great idea - do you think this would make sense as a different plugin like `jest-watch-branches`, you would hit `b` to list + typeahead branches

Allow the branch to be changed during watch mode

Hm - I like the simplicity where one key runs tests against master vs the two steps of a key to go to branch selection and a key to go...

ExceptionsManager.handleException is not a function

Commented on the PR - I'd like to take a look at this, could someone set up a minimal reproduction for me?

Persist user preferences of React DevTools when debugging with Flipper

Thanks for filing this! As mentioned in the thread, the blocker to this is reading storage synchronously when the bundle loads. Once we can do that, adding this is pretty...

Persist user preferences of React DevTools when debugging with Flipper

There is not, it's being actively worked on right now.