Paul B Mahol

add support for more native ffmpeg quality metrics

11

There is now also vif (Visual Information Fidelity), and soon identity and msad (Mean Sum of Squared Differences). They also supports slice threading and timeline (calculating quality metrics only for...

[5.8.0] Fix memory leak in r_str_list_join()

5

- [ ] Mark this if you consider it ready to merge - [ ] I've added tests (optional) - [ ] I wrote some lines in the [book](https://github.com/radareorg/radare2book) (optional)...

Fix io_ptrace UB when increasing NULL pointer

2

Fix possible overreads. - [ ] Mark this if you consider it ready to merge - [ ] I've added tests (optional) - [ ] I wrote some lines in...

- [ ] Mark this if you consider it ready to merge - [ ] I've added tests (optional) - [ ] I wrote some lines in the [book](https://github.com/radareorg/radare2book) (optional)...

Code style

13

Can this be fixed at all? Mixed tabs and spaces & mixed indentations are worst offenders.

incorrect display of limited range inputs with filtergraphs that use format filter

1

For example "Line Select", "Bit Plane" and bunch of others that use format filter to limit accepted inputs do not take into account limited range inputs with yuvj pixel formats.

strange frequency response

2

The frequency responses of FIR coefficients for various sample rates appears to be very different.

crashes if number of input samples is not power of 2

2

Looks like plugin does not set required LV2 buf size limits it supports. For example it crashes if one feed it with audio with 1152 number of samples in each...

Buggy RLS filter implementation

3

This line looks wrong: https://github.com/ar1st0crat/NWaves/blob/c1a6a4a8fdb70ce7cfd6b31ad59595e8461ff2e5/NWaves/Filters/Adaptive/RlsFilter.cs#L112 Are there any tests to make sure that this implementation behave correctly?

Shameless feature request, this transform is natural upgrade from CWT so it should be relatively easy to add.