Code style

[richardpl]

Can this be fixed at all?

Mixed tabs and spaces & mixed indentations are worst offenders.

[dericed]

+1

[retokromer]

+1

[ablwr]

Preference for existing styleguide or (even better) linter?

[dericed]

https://www.ffmpeg.org/developer.html#Code-formatting-conventions

[retokromer]

FFmpeg is a good example indeed! (The only detail I don’t like is indent 4, because 2 is fully sufficient in my opinion.)

[ElderOrb]

This is not only about tabs vs spaces. Currently QCTools uses mix of multiple naming conventions for functions/classes. Fixing all this looks like pretty big task. But after doing it right, code checker could probably be integrated into Travis to early notify about all the violations.

[retokromer]

Fixing all this looks like pretty big task.

Indeed, yet a good code editor helps a lot.

[ElderOrb]

As for the code conventions, I would suggest to follow the ones from Qt. I don't mind ffmpeg's ones but QCTools is Qt-based C++ application after all.

https://wiki.qt.io/Qt_Coding_Style https://wiki.qt.io/Coding_Conventions

[richardpl]

No point in doing it manually if job can be automated. I propose to run it under indent -kr -nut to fix issues and also to remove trailing spaces and tabs.

[ablwr]

+1 +1 +1

[retokromer]

No point in doing it manually if job can be automated.

Of course not! I personally use BBEdit since years, which does this.

[richardpl]

So, anything gonna happen anytime soon? Or I need to do it?

[ablwr]

Be the change you want to see in the world, @richardpl