Richard Barrell

Results 10 comments of Richard Barrell

Hi! I'd like some feedback on this, please. - Does this work with everyone else's workflow? I believe it works fine with using gts by running the various scripts like...

@JustinBeckwith would you be a good person from whom to request code review on this, please? Tagging you because you mentioned PRs being welcome on the issue (#490) that I'm...

Hi there! @bcoe apologies for not replying sooner, the email notification got buried in my inbox. My bad. @alexander-fenster I've rebased my branch on main and pushed it. I'm afraid...

I have another pull request with a similar purpose at #654. Is there any chance that the change I proposed is suitable for the use-case that you have, please?

Rats. I was hoping that it would be easy for Bazel users to arrange to add the eslint dir to $PATH.

@danielbankhead Thanks! I've merged `main` in to my branch and pushed.

I've merged main and pushed again.

Just thinking aloud here: 1. Maybe a better implementation would be to use https://crates.io/crates/azure_identity/0.19.0/dependencies instead of raw reqwest to construct these requests and headers. 2. I'm not sure _how_ to...

That looks right to me, but maybe put `libs: ['dom']` in as well anyway? I'm thinking that as soon as you write any code in practice, you're going to be...

@rturnq I can confirm that your suggested minimal tsconfig seems to work fine for me, thank you. 👍 I have other issues that might cause tsconfig.json recommendations to be revisited,...