gts icon indicating copy to clipboard operation
gts copied to clipboard

Added binPrefix option, to support running via Bazel

Open dorfire opened this issue 4 years ago • 8 comments

dorfire avatar Jul 12 '21 19:07 dorfire

I have another pull request with a similar purpose at #654. Is there any chance that the change I proposed is suitable for the use-case that you have, please?

richardbarrell-calvium avatar Jul 22 '21 10:07 richardbarrell-calvium

Not entirely sure; Bazel is very particular about dependency paths

On Thu, Jul 22, 2021 at 1:33 PM Richard Barrell @.***> wrote:

I have another pull request with a similar purpose at #654 https://github.com/google/gts/pull/654. Is there any chance that the change I proposed is suitable for the use-case that you have, please?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/gts/pull/653#issuecomment-884812099, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALOBK63ARRO2BJ7FIKNMKLTY7XYDANCNFSM5AHPTQUA .

dorfire avatar Jul 22 '21 11:07 dorfire

Rats. I was hoping that it would be easy for Bazel users to arrange to add the eslint dir to $PATH.

richardbarrell-calvium avatar Aug 10 '21 11:08 richardbarrell-calvium

ping @JustinBeckwith :)

dorfire avatar Aug 26 '21 14:08 dorfire

@dorfire It's been almost a year but here we go, let's finally merge it :) Would you mind signing the CLA so that we could accept your PR?

alexander-fenster avatar Jun 16 '22 08:06 alexander-fenster

I can help push this into a release if we can resolve the conflicts

tonycoco avatar Mar 22 '24 15:03 tonycoco

Not sure this change is necessary any longer. @dorfire can you comment on this being necessary still? Otherwise, will close out the PR as out of date.

tonycoco avatar Mar 27 '24 02:03 tonycoco