richardantal

Thank you @gjacoby126 for the review and for the insightful questions. I will be on holiday for a week and a half but after that I'll give further updates.

Hi @snuyanzin I've done manual testing with Phoenix, I used the sqlline with my patch and tested it there. How do you suggest testing this further in an unittest?

I link my PR to this issue: https://github.com/julianhyde/sqlline/pull/442 I am not sure if it makes sense to use getString() for every types like numbers

Thank stoty, Let me update the PR

Thank you for the review.

There is a separate PR for pre 4.10 upgrade https://github.com/apache/phoenix/pull/1474 But I'd like to trigger a test run here with these 2. I will rebase Phoenix 6653 to the master.

Thank you @stoty for the review and the suggestions, I've updated the log msgs, and added more detail to the commit message.

Thank you @stoty for the reviews, I close this PR and merge the other 2 separately.

I stopped working on this issue because there were lot of failing tests locally (outside of GMT timeZone) because of this change and I did not have the time to...

I ran the tests locally, all of them were successful, but let's wait the test result on the new version.