phoenix PHOENIX-6754 Upgrades from pre 4.10 versions are broken again

PHOENIX-6754 Upgrades from pre 4.10 versions are broken again

Open richardantal opened this issue 2 years ago • 4 comments

Jul 26 '22 12:07 richardantal

It has been removed from the addColumnMutation() setup, and the addColumnMutation() method.

Jul 26 '22 13:07 stoty

Thank stoty, Let me update the PR

Jul 26 '22 13:07 richardantal

As we have no IT for it, the real test is to manully take a dump of a skeleton Phonix 4.7 install, load it, and test if the upgrade is successful.

Jul 26 '22 13:07 stoty

I like that you put the logic inside the addColumnMutationInternal() method. LGTM, but let's add the test that we've discussed offline.

Jul 26 '22 14:07 stoty

Thank you for the review.

Aug 16 '22 07:08 richardantal