Radek Hubner

Results 50 comments of Radek Hubner

Hello @lukass77, TTL in RocksDB has the opposite guarantee that you need. It guarantees that data will be there **AT LEAST TTL** seconds. Not the opposite. > why we need...

Hello @scglenn, I'm primary familiar with Java part of RocksDB and I'm not aware of any type of this test. Problem with these types of tests is that they can...

Hello @Bindu-Bhabu, thank you for you PR. I tested your PR locally and it break our Java builds. I need to add extra parameter `-D ROCKSDB_BUILD_STATIC=ON`. I considering that previously...

Hello, I'm not able to replicate this issue. I think it was fixed already with #1106 But to be sure, I wrote test #12877 which we can merge later. Radek...

Just one comment(maybe opinion). Otherwise LGTM ✅

Hello @trazfr, thank you for amazing report. I agree that using exceptions for misses is probably not the best. I will check with my colleagues and see how we can...

Hello @alanpaxton, looks good for me. Only one question, can merge operation exit with status not found? The reason why I'm asking is because we changes signature of method `ThrowOnError`...

Hello @Mingli-001, Try [patch from this draft PR](https://github.com/facebook/rocksdb/pull/12960). It primary for ArmV7, but it may work also for ARM v5. Radek

> @rhubner I found that the test class message on failure had sense the wrong way round. I pushed a slight improvement. The PR is LGTM if you are happy...