rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Add option to CMake for building static libraries

Open Bindu-Bhabu opened this issue 1 year ago • 3 comments

ROCKSDB creates a STATIC library target reference by default. Modify the cmake so that the STATIC library is also an option just like creating a SHARED library but kept OFF by default.

Bindu-Bhabu avatar Jul 26 '24 09:07 Bindu-Bhabu

Hello @Bindu-Bhabu,

thank you for you PR.

I tested your PR locally and it break our Java builds. I need to add extra parameter -D ROCKSDB_BUILD_STATIC=ON. I considering that previously we always build static library, I think it will be better do use same defaults :

option(ROCKSDB_BUILD_STATIC "Build static versions of the RocksDB libraries" ON)

Radek

rhubner avatar Jul 26 '24 12:07 rhubner

@rhubner , default is updated, Kindly check

Bindu-Bhabu avatar Jul 26 '24 14:07 Bindu-Bhabu

LGTM ✅

rhubner avatar Jul 31 '24 08:07 rhubner