Radek Hubner

Results 50 comments of Radek Hubner

Hello @tillrohrmann and thanks for the PR. I think your code make sense. Do you think you will be able to add test for C API. We are trying to...

Hello @horizonzy thank you for reaching our community. Can you please describe your problem more. I [wrote JMH test ](https://github.com/evolvedbinary/rocksdb/blob/eb/slow-metrics/java/jmh/src/main/java/org/rocksdb/jmh/PropertyReadBenchmark.java) and I didn't notice any slowdown. Maybe if you can...

Hello @ottok , I create small patch #12944. Can you please test it and let me know if this will work. Unfortunately this is quite big change, so I put...

Hello @alim-akbashev and thanks for reaching our community, I double check code and I didn't find any misbehavior. I also [wrote small test](https://github.com/evolvedbinary/rocksdb/blob/1d5ab909a237b0598c743befab63a614bf01ccab/java/src/test/java/org/rocksdb/KeyExistsTest.java#L52) to verify your concerns. The `roptions.read_tier =...

Hi @alim-akbashev , > believe, the test will fail if we add re-opening of a db between put and keyExists/keyMayExist [That's what I did](https://github.com/evolvedbinary/rocksdb/blob/1d5ab909a237b0598c743befab63a614bf01ccab/java/src/test/java/org/rocksdb/KeyExistsTest.java#L60) Feel free to update the test....

Hello @alim-akbashev , thanks for the example. I can replicate your behavior on my machine. I think it's the [key_maye_exist](https://github.com/facebook/rocksdb/blob/6727f0f58a1251028eb22e0d74dc0551925189a2/java/rocksjni/rocksjni.cc#L1927) what return wrong result. But this happen only for TtlDB....

Hello @alim-akbashev , I did some debbuging over weeked and today and move little bit further. I will be talking primary about [DBWithTTLImpl::KeyMayExist](https://github.com/facebook/rocksdb/blob/6727f0f58a1251028eb22e0d74dc0551925189a2/utilities/ttl/db_ttl_impl.cc#L540) The first call `db_->KeyMayExist` return `true` for...

Hello @alim-akbashev , I think I found it. In [DBImpl::KeyMayExist](https://github.com/facebook/rocksdb/blob/6727f0f58a1251028eb22e0d74dc0551925189a2/db/db_impl/db_impl.cc#L3753) we always set `*value_found = true;`. Then at the end, you can see that the method return `true`, even when...

Hello @lukass77, I took over this issue from @alanpaxton  and probably found some reasons why your example doesn't work. To make it work require few prerequisites: - RocksDB must be...