rocksdb Allow specifying ReadOptions for WBWI iterator

Allow specifying ReadOptions for WBWI iterator when creating it through the C bindings. This allows to specify upper and lower bounds for the created iterator.

This fixes #12963.

Aug 24 '24 10:08 tillrohrmann

Hello @tillrohrmann and thanks for the PR.

I think your code make sense. Do you think you will be able to add test for C API. We are trying to improve C API for RocksDB and one part of it is better code coverage.

Radek

Aug 27 '24 14:08 rhubner

@rhubner sure. I'll make sure to add the required test coverage and let you know once I'm done with it.

Aug 27 '24 14:08 tillrohrmann

@rhubner, I've added tests for rocksdb_writebatch_wi_create_iterator_with_base_readopts and rocksdb_writebatch_wi_create_iterator_with_base_cf_readopts. Let me know whether this is sufficient.

Aug 28 '24 13:08 tillrohrmann

@rhubner is there anything else needed before merging this PR?

Sep 22 '24 09:09 tillrohrmann

@rhubner let me know if there is anything else missing for merging this PR.

Dec 16 '24 14:12 tillrohrmann

I've rebased this PR onto the latest main. @rhubner are there other things missing? It would help us a lot to get this C API extension merged since our project relies on it and now we have to maintain our own fork of RocksDB.

May 03 '25 15:05 tillrohrmann

@cbi42, @jaykorean could you maybe help with moving this PR forward? I've seen that you've been actively reviewing C API related PRs recently.

May 03 '25 15:05 tillrohrmann

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

May 05 '25 17:05 facebook-github-bot

@tillrohrmann Thanks for the contribution. I just imported this PR for internal review. Once approved, I will merge it and let you know. Thanks!

May 05 '25 17:05 jaykorean

@jaykorean merged this pull request in facebook/rocksdb@947a63400f201e49d16bde3af4c89a996f49c3f0.

May 06 '25 18:05 facebook-github-bot