Raúl Gutiérrez Segalés

Results 21 comments of Raúl Gutiérrez Segalés

@teeeg i am happy to help with reviews.

@teeeg should be pretty straight fwd, given that container requests are basically create requests with a different opcode: https://github.com/envoyproxy/envoy/blob/master/source/extensions/filters/network/zookeeper_proxy/filter.cc#L134

@diranged curious, are you using authentication? (i.e.: add_auth calls). The reason I ask is because of https://github.com/python-zk/kazoo/commit/15b7632fba6cbb2f31bda95eb4ca4ad327c04919. Not sure if related. Also, what's running on your servers? I do see...

i'll rebase my branch on master + add some tests

@linkensphere201 sorry missed this -- not currently but we could.

Ok I see the issue now, it's `true` by default if `aws-load-balancer-security-groups` is not set. If `aws-load-balancer-security-groups` is set, then you must specifically opt in. I'll update the docs to...

@Yasumoto could you review please?

@dvrybak hmm, i think https://github.com/twitter/zktraffic/commit/2643c59fc9d007472f24922aace8d84e5e5c28f3 needs a follow-up. We probably should get rid of twitter common unless it gets proper py3 support.