Raúl Gutiérrez Segalés
Raúl Gutiérrez Segalés
For anyone else reading this, we bumped into a similar issue when setting up upstream TLSContexts with the same name in different namespaces. In this scenario, we had parallel Emissary...
I think something like this should repro this (not tested): ``` --- apiVersion: getambassador.io/v3alpha1 kind: Host metadata: name: a-host spec: hostname: '*.domain.com' requestPolicy: insecure: action: Redirect tlsContext: name: tlscontext tlsSecret:...
FWIW, testing this internally along with #3985 plus atlantis-drift-detection seems to working for us. We'll put some load on it and see if it's reliable.
We've been using for more than a few months now, still looking good.
@kflynn of course, I'l send a PR 🙂
Somewhat related: https://github.com/runatlantis/atlantis/pull/4865
Ah yes, similar... hmm let me compare this to what my PR is doing.
Ok they are pretty much the same, except that this one will return earlier which is probably better than looping for longer and defaulting to setting `refTarget ` (which should...
@jamengual 2nd try – this makes HeadCommit and BaseBranch optional parameters. If they are missing, we fallback to the existing behavior which I guess works fine as long as your...
Thanks for the review @chenrui333. Just pushed an updated commit with the existing test updated, so that it exercises the new fields.