Roland Grunberg
Roland Grunberg
Currently the server is entirely responsible for diagnostics by sending them over to the client. We do this as part of project import, and also based on opened documents (ie....
You mentioned you're using LSP4J as the client, so you'll need to look at the LSP4J client API parts and see if there is a clear way to connect to...
I think https://github.com/eclipse-lsp4j/lsp4j/blob/main/org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/services/LanguageServer.java would be the interface you need. If you're looking at https://www.eclipse.org/community/eclipse_newsletter/2017/may/article2.php , my guess is you'd need to implement the "Connecting to the Chat Server" portion (eg....
I think it should be fine to customize the chain completion rendering with this logic. The only part that I would want to look closely at is the `isChainCompletion` check....
If you look at the protocol spec, you'll see `activeParameter?: uinteger;` . The question mark implies property is optional, and so it's perfectly valid to provide `SignatureHelp` response that doesn't...
https://github.com/eclipse/eclipse.jdt.ls/blob/fecf51c318e766dc81acc414a1544ccd79ef4604/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/SignatureHelpUtils.java#L195 :neutral_face:
You're right. If `activeParameter` is not defined it seems to imply it treats it as the 1st (0) parameter being the active one. We definitely don't want to break this...
> If omitted or the value lies outside the range of signatures[activeSignature].parameters defaults to 0 if the active signature has parameters Looking back, it is confusing. I just intepreted the...
A while ago we had a discussion where you mentioned that `.classpath`, `.settings` files can be set using linked resources, so doing this is likely the right approach. We should...
@jdneo do you think you might have time to look here. I see this is completely removing the `jdt.ls.filesystem` bundle so definitely would be nice to thoroughly test this.