Roland Grunberg
Roland Grunberg
I would think `language/progressReport` should be phased out in favour of this. Looks like it was introduced in [3.15.0](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#progress). @testforstephen thoughts ?
So emitting duplicate event endpoints is the least volatile approach because each client can choose to subscribe to `$/progress` or continue with `language/progressReport` (until we remove it). @fbricon doesn't want...
> unnecessary events consume CPU. If you need to support both during a transition period, I suggest you use a feature flag to enable one of them only. Remove the...
> Given that `$/progress` is part of the specification, would it make sense to send `language/progressReport` if `progressReportProvider` is true (like the current behavior) and if it is absent or...
Ok, just spoke to @fbricon . When `isProgressReportSupported()` is `true`, report with `language/progressReport` (same as now) and do not report `$/progress`. Otherwise, report with `$/progress` and do not report with...
Overall, I think this looks good. Is it possible to add a testcase in `ProgressReporterManagerTest` that confirms `notifyProgress` is called when `isProgressReportSupported()` is false ?
> Thanks, i have had a look at the formatter settings, the second link however seems promising. Seems like that settings file will be sufficient to add user defined properties....
Really nice timing on fixing that issue :) I think it should make providing diagnostics a lot easier for other JDT-LS extensions. Feel free to report if there's something not...
Closing this issue for now but feel free to re-open if there is still an issue. As an example, see https://github.com/jbangdev/jbang-eclipse/blob/c50a5d6be22d57ecbb4b6c39d8a385fb877a6c7b/dev.jbang.eclipse.core/src/main/java/dev/jbang/eclipse/core/internal/project/ProjectConfigurationManager.java#L439 . With an `IResource#createMarker(..)`, it should be enough to...
The codeql-analysis seems nearly identical to what we do in https://github.com/eclipse/lemminx/blob/master/.github/workflows/codeql-analysis.yml , so should be fine. What does the dependabot config provide that's different from https://github.com/eclipse/eclipse.jdt.ls/issues?q=dependabot that I assume is...