Roland Grunberg

Results 612 comments of Roland Grunberg

Is there a concrete example of this ? Is there a case where an interface method ends up in the call hierarchy ? If I just perform call hierarchy on...

Is there any reason this wasn't enabled by default in Eclipse ? I think it's reasonable to set this. So if an outgoing call is done through an interface, where...

CC'ing @robstryker @fbricon as requested. Here's the snippet behaviour I was referring to : Note : This is only a problem on a **Java 21** EE (in fact probably Java...

We could increase this, but as mentioned in https://github.com/eclipse-jdtls/eclipse.jdt.ls/pull/2730#issuecomment-1620725555, I think we'll be limited by the performance of the chain search. Increasing the maximum chains might not necessarily mean more...

Could we use `ChainFinder` directly from jdt.core.manipulation. I'd be fine with merging directly in there if anything extra is needed.

Yes, I plan to review this. I'm guessing if we merge this, we can also close https://github.com/eclipse-jdtls/eclipse.jdt.ls/pull/2935 (that commit is included here) ? I guess my only complaint there was...

Also, there appear to be some test failures : https://ci.eclipse.org/ls/job/jdt-ls-pr/5176/ . The ones in CompletionHandlerChainTest seem consistent.

PDE definitely wouldn't be in the target platform of JDT-LS, so not sure why it would be needed. It should be part of the platform from which you're launching the...

Similar request in https://github.com/redhat-developer/vscode-java/discussions/3341 . I don't like the approach of tracking it ourselves because I think searching by references in the search engine (index) would be much nicer. The...

You're command includes `-jar E:/server/jdt-language-server-1.28.0-202309281329/plugins/org.eclipse.equinox.launcher.win32.win32.x86_64_1.2.700.v20221108-1024.jar` . There are a few `equinox.launcher` bundles : ``` $ ls -1 | grep equinox.launcher org.eclipse.equinox.launcher_1.6.500.v20230717-2134.jar org.eclipse.equinox.launcher.cocoa.macosx_1.2.700.v20221108-1024.jar org.eclipse.equinox.launcher.cocoa.macosx.aarch64_1.2.700.v20221108-1024.jar org.eclipse.equinox.launcher.cocoa.macosx.x86_64_1.2.700.v20221108-1024.jar org.eclipse.equinox.launcher.gtk.linux.aarch64_1.2.700.v20221108-1024.jar org.eclipse.equinox.launcher.gtk.linux.x86_64_1.2.700.v20221108-1024.jar org.eclipse.equinox.launcher.win32.win32.x86_64_1.2.700.v20221108-1024.jar ``` You want...