Richard Gomez

Results 129 comments of Richard Gomez

> After 1 Minute of Code Review, I found this weird line. > > Does nobody look at the code, before using it (with admin privilidges)? I noticed that as...

Reproducible on: ```sh java -version openjdk version "11.0.13" 2021-10-19 OpenJDK Runtime Environment 18.9 (build 11.0.13+8) OpenJDK 64-Bit Server VM 18.9 (build 11.0.13+8, mixed mode, sharing) ``` Stack trace from 2021-12-22:...

@donmontalvo Can you provide some more information about your setup? I can't reproduce this with either 2021.12.20 or 2021.12.22. ```sh $ git clone https://github.com/mergebase/log4j-samples.git $ java -jar log4j-detector-2021.12.20.jar log4j-samples/ --...

> I've noticed a problem with Github where people right-click download links like this: "https://github.com/mergebase/log4j-samples/blob/master/true-hits/log4j-core-2.10.0.jar". It seems to download as a jar file, but it's not. It's an html file....

> Spoke too soon. It's giving strange output on ZIP files. I think that's related to #56

Hey @HynekPetrak, can you elaborate on why that code is problematic? The code was added to address edge cases like #49, and only seems to warn that log4j-core _may_ be...

> Purpose of this library is for sure not, to bridge between "regular" and coroutine code, but **I really like the idea of having a uni builder for sake of...

This is a bit trickier than anticipated. Coroutines launched inside `Uni.createFrom().emitter` won't run, presumably because the block returns immediately. Most of the ["official" extensions under `kotlinx.coroutines`](https://github.com/Kotlin/kotlinx.coroutines/blob/5e870c11311b3bfd58f0557c651f1d877e9e5827/reactive/kotlinx-coroutines-reactor/src/Mono.kt#L93-L96) implement `AbstractCoroutine`, which is...

> It would be super useful for our use case to be able to run a custom configuration against the result of a decoded base64 string. > To make it...

Perhaps general verification steps could be listed alongside remediation advice on https://howtorotate.com/?