Richard Gomez

Results 129 comments of Richard Gomez

> Got error unarchiving chunk and invalid header error. Fails to find the secret. > ... > Works on 3.60.4, but updating breaks the scan. Are you sure that these...

This could be automated to an extent: subdomains that no longer resolve or domains that have expired are easy to check, behavioral changes are a bit harder. I am curious...

I'm guessing that a-z and 0-9 are meant to exclude regex patterns such as `"password":"[a-z0-9]{32}`. I'm not sure how effective it is, though. I'm working on a PR for Azure...

On that note, using `trufflehog github` with comment scanning enabled makes code scanning much slower because [it cannot scan the next repository until `scanComments` has completed](https://github.com/trufflesecurity/trufflehog/blob/2a66d4117a3f14b14f97e07668615bac905e4e5e/pkg/sources/github/github.go#L800-L807). Scanning comments ("metadata") is...

It would be helpful if you provide specific examples that can be tested against (redact/placeholders, obviously).

This seems trivial to implement: ```sh # assuming the origin is GitHub, which can be checked with `git ls-remote` git fetch origin "+refs/pull/*:refs/heads/pull/*" ```

@zricethezav this should be ready for review now.

> ...and require the application to provide the additional information about the default and requirement using @Schema. Interestingly `@Parameter` also works, but only if you explicitly declare `required = false`...