Richard Gomez

Results 129 comments of Richard Gomez

> In this example, the co routine handle is dependent on the router instance, you could mix by having several routers and use `subRouter()` to merge them. > > Alternatively......

Is there an opportunity to use [`kotlinx.serialization`](https://github.com/Kotlin/kotlinx.serialization) here instead? My understanding is that encoders/decoders are generated at compile-time, which would mitigate security concerns associated with Jackson's use of reflection. Not...

The intention is evidently to provide the reason _why_ the JWT is expired, however, I agree that it's awkward. JWTAuthProviderImpl has this strange block which will never return because `isExpired()`...

> Also did you sign the Eclipse CLA? I did. :+1:

@vietj Here's my first pass at #46, let me know your thoughts. There is an issue resolving the dependencies for the latest snapshot (hence Travis CI failure), but it works...

The meat of the changes are in the first commit (https://github.com/vert-x3/vertx-circuit-breaker/pull/47/commits/8e3d35e7dfb81959cb13507286ce38bbbbff81e5), https://github.com/vert-x3/vertx-circuit-breaker/pull/47/commits/b8efb6835c4f4c08c626bfdd529fe0449c556cfc just provides some enhancements.

@vietj @gmariotti Any news on this? This (or #229) would be a huge QoL improvement for Kotlin. Since 3.6.0 there is no Kotlin equivalent for static factory methods.

Not Vertx-specific but Spring [recently added support for data classes (29.5)](https://docs.spring.io/spring-boot/docs/2.2.0.BUILD-SNAPSHOT/reference/html/spring-boot-features.html#boot-features-kotlin-configuration-properties). It might be worth looking into how they accomplished that.