rey

Results 17 comments of rey

Thanks for your contributions @jdavidberger, I will try to check this and get back to you by this weekend.

The functionality you wanted to achieve, could be done using default params instead of overloading functions. Previously, the default values were present in pybind but missing in cpp, so I...

> Is there anything more I need to do for this pr? I don't think so. The PR looks good to merge. Thanks for your contribution.

Removed `floating_precision`. Using `ReinterpretCast`.

I would highly recommend using the new API. The legacy colored-ICP API has some issues, but it is going to be depreciated soon anyways. Documentation: http://www.open3d.org/docs/latest/tutorial/t_pipelines/t_icp_registration.html#Case-of-no-correspondences. Thanks

TODO: Fix a design for storing example outputs if any. Suggestion: `open3d_data / example_results / example_name / ` This will also be followed later for the reconstruction system, where there...

- added review changes. - added `data.output_dir` [like `data.extract_dir`], to return the absolute path to an output dir corresponding to the dataset to store results. i.e. `open3d_data/output/dataset_name/`. Currently, the reconstruction...

Thanks for the PR @theNded. I will take care of the mentioned list. Also, I was trying to come up with a new design if possible such as: - Currently,...

Hi @heethesh, may we have a zoom call for discussion? In my review, I found this can be merged with the existing ICP interface with some changes, and we can...