Pranshu Srivastava
Pranshu Srivastava
Please be advised that using `node-role.kubernetes.io/*` to assess a node's nature is [standard practice](https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io), and AKS breaks this downstream. This needs to be fixed on their end.
I see, this moves `endpoints` out of the default set of resources for which we generate metrics for, and users will need to use the `--resources` flag to re-enable it....
/lgtm /hold To give time to other discussion(s) here, feel free to unhold.
Locally, on `main`, with all binaries on the latest version, I keep getting the following error on `make --always-make format generate`, which seems to be solved when using `gsed`. But...
Looking into it.
Tested downstream (CMO), on enabling `upstreamProbesOptIn`. ```diff diff --git a/assets/kube-state-metrics/deployment.yaml b/assets/kube-state-metrics/deployment.yaml index ec651432e..e73091269 100644 --- a/assets/kube-state-metrics/deployment.yaml +++ b/assets/kube-state-metrics/deployment.yaml @@ -57,7 +57,19 @@ spec: ^kube_pod_completion_time$, ^kube_pod_status_scheduled$ image: registry.k8s.io/kube-state-metrics/kube-state-metrics:v2.13.0 + livenessProbe: +...
- [x] Add a comment describing the way probes are defined and expected to work.
@simonpasquier Pushed all the suggested changes but `s/defaults.ignorePaths/[]` and `s/super.ignorePaths/[]` since I believe these will always be `[]`, in addition to the current implementation allowing for a single source of...
Tested on a cluster, seems to work now. I've made KRP's ports the single source of truth for KSM's probes and ports for convenience. PTAL below for downstream diff. ```diff...