Pranshu Srivastava

Results 524 comments of Pranshu Srivastava

[I'd say so.](https://github.com/kubernetes/kube-state-metrics/blob/ca569e1ffe2e0387a19351fd3a9e2c4d87e474df/internal/store/endpointslice.go#L152)

/lgtm Thank you for all the great work, not just this PR, but everything! 🙇

Since we're closing in on 1.28 in a couple of months, I'd like to work on this. 🙂

> make sure that clients can't submit ambiguous requests [...] ACK, IIUC the validation can be accomplished by [checking the spec against the expected schema](https://github.com/prometheus-operator/prometheus-operator/pull/5706/files#diff-b51086a9eecc900f44fb39e672c73f66396d84c48d15f5d86c8106cea04a4920R285). Also, I've added this for...