Pranshu Srivastava
Pranshu Srivastava
/lgtm /hold For others to take a look.
/cc @dgrisonnet
Seconding @dgrisonnet, I realized syncing caches at the first run isn't going to help us do that throughout the lifecycle. Resyncs weren't an option either since the event could always...
- [ ] TODO: https://github.com/kubernetes/enhancements/pull/4811#discussion_r1834046385
@mrueg Regarding naming the managed resource `CustomResourceMetricsConfig`, I agree with the change, however, since a rename will entail renaming the repository and a good amount of refactor (mostly variable names...
ACK, I believe there's only one planned for now. Building on the suggestions above, you think `CRMetricsMonitor` would be a good idea? cc @sftim
Ah, nice catch! That makes perfect sense. For the repository name though, I'm thinking something along the lines of `resource-metrics-operator`?
+100! I'll make the changes. Thanks a bunch for all the sound suggestions here! 🚀
Hmm, I believe that can be left out in case of controllers? For instance, [this](https://github.com/kubernetes/ingress-nginx) or [this](https://github.com/kubernetes/ingress-gce)? Correct me if I'm wrong here, but the only `controller`-suffixed repository I found...
I've tried to move things accordingly after archiving https://github.com/rexagod/crdmetrics/ in favor of https://github.com/rexagod/resource-state-metrics, but PLMK if I missed something. I believe with the the latest patch, all reviews till now...