Pranshu Srivastava comments

Results 524 comments of


                                            Pranshu Srivastava

Create CODE_OF_CONDUCT.md

@jywarren Please review.

Fix `examples/*html` in `gh-pages` branch to show a working demo

Sure, go ahead @Abandolon!

Fix `examples/*html` in `gh-pages` branch to show a working demo

Try force pushing the changes to your `gh-pages` branch: `git push gh-pages --force`.

[WIP] Inline Editor won't save changes

_I maybe wrong about this. Currently trying out the aforementioned approach on local._

[WIP] Inline Editor won't save changes

Seems to work on custom urls. Testing if `/wiki/replace/`is sending a 200?

use standardized abstract geocoding library

>Currently, the request for Maps API with the `node-geocode` reverse method returns `Error: Response status code is 400 at exports.IncomingMessage. (Leaflet.BlurredLocation.js:50887) at emitNone (Leaflet.BlurredLocation.js:31507) at exports.IncomingMessage.emit (Leaflet.BlurredLocation.js:31587) at endReadableNT (Leaflet.BlurredLocation.js:61376)...

Cut down multiple API requests from Geocoding.js

Yes, @jywarren, right after running `grunt jasmine`, [even on the successful ones](https://travis-ci.org/publiclab/leaflet-blurred-location/jobs/496235098).

Resolve linting errors

@osbornetunde Go ahead, and let us know if you face any problems whatsoever. Thanks!

Testing Suites

As far as mocking support is concerned, along with ananyo's concerns, I'd say the we should give Jest a spin. It wasn't there back in 2012, or wasn't atleast popular...

Testing Suites

``` var div = document.createElement('DIV'); div.setAttribute('id','xyz'); ... ... div.parentNode.removeChild(div); ``` Dynamically create, run tests on, and remove the `div`.