publiclab
Resolve linting errors
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
Problem
📋Solution
-
[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
-
[ ] 📝 Update
// install ESLint
$ npm i -g eslint
// navigate and run linter
$ cd simple-data-grapher && eslint --fix .
// format code to fix linting errors
After the errors are fixed, proceed as specified below.
-
[ ] 💾 Commit your changes
-
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
-
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
-
You can also edit files directly in your browser and open a pull request from there.
- [ ] 🏁 Done Ask in comments for a review :)
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
@osbornetunde Go ahead, and let us know if you face any problems whatsoever. Thanks!
Yes! When you clone the repo, do npm install to install the dependencies, and do npm run build, to see the changes in the main file. We'll be updating the README.md soon. Thanks a lot!n Fri, Jun 21, 2019, 1:00 AM Osborne Tunde [email protected] wrote:
I claim this
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/50?email_source=notifications&email_token=AJXHQZZAM6FVY5MJJT7DNFDP3PLDRA5CNFSM4HZOCYJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYGMHYY#issuecomment-504153059, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ2U5ANZARQV6WTZOQTP3PLDRANCNFSM4HZOCYJQ .
Hey can you add a WIP label to tickets that have already been picked up to make it clear that they are taken?
I think you can give it a try!
On Tue, Oct 1, 2019, 1:07 AM Hemang Bhogayata [email protected] wrote:
Still Open for Solving ? Would like to have a go at this one
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/50?email_source=notifications&email_token=AJXHQZ3LCV4LBWMPI6WEUBDQMJIRJA5CNFSM4HZOCYJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7623II#issuecomment-536718753, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ6XAXK7SLKYLLNODRDQMJIRJANCNFSM4HZOCYJQ .
Sure!
On Sat, Oct 19, 2019, 3:21 PM raksh07 [email protected] wrote:
Hi can I try this issue
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/50?email_source=notifications&email_token=AJXHQZZNCIJ2XT3NFSOB2RTQPLKCBA5CNFSM4HZOCYJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXKJYQ#issuecomment-544122082, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXHQZ2EGH2BZAJ4CVRCVNDQPLKCBANCNFSM4HZOCYJQ .
Hey! I would like to lend a hand on this as well! :slightly_smiling_face:
Sure!
On Wed, Oct 30, 2019, 5:47 PM Vishnuprasad Venugopal < [email protected]> wrote:
Hi, Can i try?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/50?email_source=notifications&email_token=AJXHQZYE26ZHMFPYX6MVIVDQRF3NJA5CNFSM4HZOCYJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECT6G5Q#issuecomment-547873654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXHQZYX3GY2UOBRZIFRPZLQRF3NJANCNFSM4HZOCYJQ .