Pranshu Srivastava
Pranshu Srivastava
Verified using the following configurations. Error logs were reported without this patch, but none when this was applied. Details ### Prometheus error log ``` ts=2023-12-13T16:01:02.547Z caller=scrape.go:1418 level=debug component="scrape manager" scrape_pool=kube-state-metrics...
A couple of notes around the latest patch. * The earlier approach used `strings.Has*` and `strings.LastIndex` functions, with respective complexities of O(1) and O(n). This patch removes the dependency on...
Posting baseline benchmarks, forgot to do this earlier. * Baseline (same as `main`) v/s changes in this PR. ``` goos: darwin goarch: arm64 pkg: k8s.io/kube-state-metrics/v2/pkg/metrics_store │ BASELINE │ HEAD │...
Added a couple of O(1) checks from the first commit back in. The benchmarks may differ slightly, but the overall inference should be the same.
Good for reviews.
/hold Need to add a test too, will push shortly.
Pasting the requested information below. Testing locally on a Prometheus Protobuf setup. Benchmarking this PR against `main`. ``` goos: darwin goarch: arm64 pkg: k8s.io/kube-state-metrics/v2/pkg/metrics_store │ BASELINE │ HEAD │ │...
/cc @dgrisonnet (for another review before merging)
@dgrisonnet I believe all concerns have been addressed, can you PTAL once more (and LGTM if this looks good to you)?