Pranshu Srivastava comments

Results 524 comments of


                                            Pranshu Srivastava

fix: fallback to `gauge` for `protofmt`-based negotiations

@dgrisonnet Yes, I believe we talked about dropping metric-standard lock-ins, and implementing a one-fits-all mechanism (probably on top of gauges) that allows us to generate an exposition format that is...

fix: fallback to `gauge` for `protofmt`-based negotiations

(friendly ping @mrueg @dgrisonnet to /lgtm)

fix: fallback to `gauge` for `protofmt`-based negotiations

It should, yes.

fix: fallback to `gauge` for `protofmt`-based negotiations

I'll put https://github.com/kubernetes/kube-state-metrics/pull/2335 up for review today.

fix: fallback to `gauge` for `protofmt`-based negotiations

Sharing here for visibility: https://github.com/kubernetes/kube-state-metrics/pull/2335#issuecomment-2032148989.

feat: validate stable metrics via static analysis, which adapts codes from k/k stable metrics framework

Ah! I missed this, thank you for all the great work here! I'll review this ASAP! Sorry for the delay here! :/

feat: validate stable metrics via static analysis, which adapts codes from k/k stable metrics framework

@CatherineF-dev How about adding this PR to the SIG weekly agenda? Just a high-level introduction of what this does while gathering feedback from the rest of the SIG should make...

Simplify custom resource state metrics API using CEL

While this is easily one of the features we'd like to see implemented, tested, and polished enough throughout `v2.x` releases to finally make its way into `v3`, I just want...

docs: Add guide on how to debug CustomStateMetrics feature quickly

The change seems fairly straight-forward. I'd suggest adding a section demonstrating the usage of https://github.com/go-delve/delve to catch contexts at breakpoints set by the user.

feat: add kube_pod_container_status_last_terminated_timestamp metric

@tetianakravchenko Tests seem to be failing here.